Skip to content

fix(connector): [braintree] add 3ds redirection error mapping and metadata validation #2552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 12, 2023
Merged

fix(connector): [braintree] add 3ds redirection error mapping and metadata validation #2552

merged 9 commits into from
Oct 12, 2023

Conversation

SamraatBansal
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add Error Mapping Scenarios for 3DS payments
  • Add connector_meta_data validation for Braintree
  • Add InvalidConfig ConnectorError in case of missing metadata configs

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 11, 2023
@SamraatBansal SamraatBansal self-assigned this Oct 11, 2023
@SamraatBansal SamraatBansal requested review from a team as code owners October 11, 2023 17:56
Narayanbhat166
Narayanbhat166 previously approved these changes Oct 11, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik approved these changes Oct 12, 2023
View reviewed changes
ArjunKarthik
ArjunKarthik suggested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@ArjunKarthik ArjunKarthik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@ArjunKarthik ArjunKarthik removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 12, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 28d02f9 Oct 12, 2023
@ArjunKarthik ArjunKarthik deleted the fix/braintree-redirection-error-mapping branch October 12, 2023 13:42
@SanchithHegde SanchithHegde removed the P-high Priority: High label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasunna09 prasunna09 prasunna09 approved these changes

+2 more reviewers

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamraatBansal @ArjunKarthik @Narayanbhat166 @prasunna09 @SanchithHegde