-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: percentage float inconsistency problem and api models changes to support surcharge feature #2550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple_connectors_service
15 tasks
Narayanbhat166
previously approved these changes
Oct 11, 2023
…ayment_method_data types
Narayanbhat166
approved these changes
Oct 12, 2023
jarnura
approved these changes
Oct 12, 2023
SanchithHegde
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Using float to deserialize the percentage was giving incorrect values. Hence changing deserializing percentage float value to
serde_json::Value and then calling to_string() on it.
Percentage object will look like this:
List of changes in this PR:
surcharge_amount
,tax_on_surcharge_amount
,final_amount
)payment_Attempt.surcharge_metadata
.struct PaymentsSessionData
and populated it from payment_data.struct PaymentsAuthorizeData
and populated it from payment_data.Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy