Skip to content

fix(router): add customer_id validation for payment method create flow #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 12, 2023
Merged

fix(router): add customer_id validation for payment method create flow #2543

merged 6 commits into from
Oct 12, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Oct 11, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Payment method create takes any customer_id that is being passed, this pr adds validation for the customer_id that is being passed.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Payment Method Create
-> when customer is not present
image
-> when customer is present
image
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Oct 11, 2023
@ShankarSinghC ShankarSinghC added this to the October 2023 Milestone milestone Oct 11, 2023
@ShankarSinghC ShankarSinghC requested a review from vspecky October 11, 2023 10:39
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner October 11, 2023 10:39
@ShankarSinghC ShankarSinghC self-assigned this Oct 11, 2023
sai-harsha-vardhan
sai-harsha-vardhan requested changes Oct 12, 2023
View reviewed changes
@vspecky vspecky added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 53d7604 Oct 12, 2023
@vspecky vspecky deleted the fix-payment-methods-create branch October 12, 2023 09:40
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sai-harsha-vardhan sai-harsha-vardhan sai-harsha-vardhan approved these changes

+2 more reviewers

@vspecky vspecky vspecky approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods C-bug Category: Bug
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShankarSinghC @vspecky @Narayanbhat166 @sai-harsha-vardhan @SanchithHegde