Skip to content

feat(connector): [GlobalPayments] Introduce connector_request_reference_id for GlobalPayments #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 10, 2023
Merged

feat(connector): [GlobalPayments] Introduce connector_request_reference_id for GlobalPayments #2519

merged 6 commits into from
Oct 10, 2023

Conversation

amaan14999
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@amaan14999
feat(connector): [GlobalPayments] Use connector_request_reference_id …
c39dfba 
…as reference to the connector

Introduces the connector_request_reference_id field in the RouterData structure to improve consistency in transmitting payment information to the GlobalPayments payment gateway. This new ID will replace the usage of payment_id and attempt_id, aligning with the GlobalPayments API requirements for referencing payments.

This change ensures that all payment requests to GlobalPayments use a unified reference ID, reducing potential confusion and streamlining the integration process.

Fixes juspay#2300
@amaan14999
Merge branch 'juspay:main' into main
f963422
@amaan14999 amaan14999 requested a review from a team as a code owner October 10, 2023 05:28
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 10, 2023
@prasunna09 prasunna09 linked an issue Oct 10, 2023 that may be closed by this pull request
[FEATURE]: [GlobalPayments] Use connector_request_reference_id as reference to the connector #2300
Closed
2 tasks
srujanchikke
srujanchikke approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prasunna09 prasunna09 added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 10, 2023
@ArjunKarthik ArjunKarthik added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Oct 10, 2023
@ArjunKarthik
Copy link
Contributor

@amaan14999 Thanks for the PR

@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 10, 2023
Merged via the queue into juspay:main with commit 116139b Oct 10, 2023
@VedantKhairnar
Copy link
Contributor

Hey @amaan14999 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasunna09 prasunna09 prasunna09 approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

+1 more reviewer

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@amaan14999 amaan14999

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [GlobalPayments] Use connector_request_reference_id as reference to the connector
5 participants
@amaan14999 @ArjunKarthik @VedantKhairnar @prasunna09 @srujanchikke