feat(nexinets): Use connector_request_reference_id as reference to the connector - Work In Progress #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-conventions-not-followed
frazar
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
frazar
force-pushed
the
nexipay-connector_request_reference_id
branch
2 times, most recently
from
da0725d to
beecccd
Compare
prasunna09
added
A-connector-integration
| @@ -179,6 +180,7 @@ impl TryFrom<&types::PaymentsAuthorizeRouterData> for NexinetsPaymentsRequest { | |||
| product, | |||
| payment, | |||
| nexinets_async, | |||
| merchant_order_id: Some(item.connector_request_reference_id.clone()), | |||
There was a problem hiding this comment.
Hi @frazar ,
as per api docs of nexinets merchant_order_id can only be sent in case of cards . So this should only be populated incase of card payments .
let merchant_order_id = match item.payment_method {
// Merchant order id is sent only in case of card payment
enums::PaymentMethod::Card => Some(item.connector_request_reference_id.clone()),
_ => None,
};
There was a problem hiding this comment.
Thank you! I applied the suggested changes.
srujanchikke
previously approved these changes
Oct 11, 2023
|
Please make the suggested changes , Other than that looks good to me |
frazar
force-pushed
the
nexipay-connector_request_reference_id
branch
2 times, most recently
from
fe72903 to
e01173c
Compare
The reference is passed as the "merchantOrderId" attribute, as described in NexiNets documentation: https://developer.nexigroup.com/payengine/en-EU/api/payengine-api-v1/#orders-debit-post
frazar
force-pushed
the
nexipay-connector_request_reference_id
branch
from
e01173c to
eff5605
Compare
SanchithHegde
approved these changes
Oct 13, 2023
|
Thank you all for your guidance and support! |
SanchithHegde
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
For all payment methods, Hyperswitch should transmit a reference to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
In this PR, such reference is obtained by calling
connector_request_reference_id()inRouterData. The result is then passed as the "merchantOrderId" parameter to the NexiNets API, as per the official documentation.Additional Changes
Motivation and Context
Fixes #2307
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy