Skip to content

Conversation

Sarthak1799
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

another field was required for bank account creds in payment method data.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sarthak1799 Sarthak1799 added A-payment-methods Area: Payment Methods C-refactor Category: Refactor labels Oct 8, 2023
@Sarthak1799 Sarthak1799 requested a review from vspecky October 8, 2023 06:57
@Sarthak1799 Sarthak1799 self-assigned this Oct 8, 2023
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner October 8, 2023 06:57
@vspecky vspecky requested a review from Narayanbhat166 October 9, 2023 11:00
@vspecky vspecky added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 labels Oct 9, 2023
@vspecky vspecky added this to the September 2023 Milestone milestone Oct 9, 2023
@vspecky vspecky added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L2 labels Oct 10, 2023
@vspecky vspecky added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit ac3c500 Oct 10, 2023
@vspecky vspecky deleted the pmd-mca-id branch October 10, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

4 participants