refactor: add support for passing context generic to api calls #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
S-waiting-on-review
Chethan-rao
force-pushed
the
add_ctx_generic
branch
4 times, most recently
from
a5e1215 to
de83d0b
Compare
Chethan-rao
force-pushed
the
add_ctx_generic
branch
from
de83d0b to
763fef4
Compare
vspecky
previously approved these changes
Oct 5, 2023
| payment_data.token = Some(parent_payment_method_token); | ||
| } | ||
| (Some(_), _) => { | ||
| let payment_method_data = Ctx::retrieve_payment_method( |
There was a problem hiding this comment.
Nitpick, always prefer destructuring tuples. (payment_method_data, payment_token). Not a blocker tho
jarnura
approved these changes
Oct 5, 2023
vspecky
approved these changes
Oct 6, 2023
vspecky
added
S-ready-for-merge
and removed
R-waiting-on-L2
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR includes changes for adding a new generic, context, which will be passed during api call (server_wrap) to call the related implementation depending on context
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy