Skip to content

refactor(router): add camel_case for the applepay request #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2023
Merged

refactor(router): add camel_case for the applepay request #2172

merged 1 commit into from
Sep 15, 2023

Conversation

prajjwalkumar17
Copy link
Member

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

We need to provide camel case keys in applepay request.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prajjwalkumar17 prajjwalkumar17 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods C-refactor Category: Refactor R-waiting-on-L1 labels Sep 15, 2023
@prajjwalkumar17 prajjwalkumar17 self-assigned this Sep 15, 2023
@vspecky vspecky added this pull request to the merge queue Sep 15, 2023
Merged via the queue into main with commit 4c36fcb Sep 15, 2023
@vspecky vspecky deleted the fix/applepay_req_case branch September 15, 2023 11:10
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 labels Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura Awaiting requested review from jarnura

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

2 more reviewers

@lsampras lsampras lsampras approved these changes

@vspecky vspecky vspecky approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
A-payment-methods Area: Payment Methods C-refactor Category: Refactor
Projects
None yet
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prajjwalkumar17 @lsampras @vspecky @SanchithHegde