feat(connector): [Braintree] implement 3DS card payment for braintree #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanchithHegde
added
A-connector-integration
ArjunKarthik
suggested changes
Sep 8, 2023
crates/router/src/connector/braintree/braintree_graphql_transformers.rs
Outdated
Show resolved
Hide resolved
crates/router/src/connector/braintree/braintree_graphql_transformers.rs
Outdated
Show resolved
Hide resolved
crates/router/src/connector/braintree/braintree_graphql_transformers.rs
Outdated
Show resolved
Hide resolved
crates/router/src/connector/braintree/braintree_graphql_transformers.rs
Outdated
Show resolved
Hide resolved
crates/router/src/connector/braintree/braintree_graphql_transformers.rs
Outdated
Show resolved
Hide resolved
ArjunKarthik
added
the
S-waiting-on-author
AkshayaFoiger
removed
the
S-waiting-on-author
prasunna09
previously approved these changes
Sep 11, 2023
AkshayaFoiger
force-pushed
the
braintree_threeDS
branch
from
36405cf to
d896693
Compare
ArjunKarthik
approved these changes
Sep 12, 2023
prasunna09
approved these changes
Sep 12, 2023
SanchithHegde
approved these changes
Sep 12, 2023
| h3 style="text-align: center;" { "Please wait while we process your payment..." } | ||
| } | ||
|
|
||
| (PreEscaped(format!("<script> |
There was a problem hiding this comment.
You can use raw string literals to improve readability.
There was a problem hiding this comment.
Will take up this change in a different PR
ArjunKarthik
added
S-ready-for-merge
and removed
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
How did you test it?
Tested It through postman
Checklist
cargo +nightly fmt --allcargo clippy