Skip to content

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added error for the card networks which are not configured via merchant.

How did you test it?

tested via account which has not configured one network like Rupay and tested with that flow. the error was being thrown and confirm call didn't happen.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label May 9, 2024
@sakksham7 sakksham7 self-assigned this May 9, 2024
PritishBudhiraja

This comment was marked as resolved.

Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✨

@prafulkoppalkar prafulkoppalkar merged commit f14c591 into main May 10, 2024
@prafulkoppalkar prafulkoppalkar deleted the card-brand-configuration branch May 10, 2024 07:11
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label May 10, 2024
akash-c-k pushed a commit that referenced this pull request May 10, 2024
## [0.50.12](v0.50.11...v0.50.12) (2024-05-10)

### Bug Fixes

* card brand configuration error added ([#362](#362)) ([f14c591](f14c591))
@PritishBudhiraja PritishBudhiraja linked an issue May 13, 2024 that may be closed by this pull request
rising-dragon401 added a commit to rising-dragon401/hyperswitch-web that referenced this pull request Jul 2, 2024
## [0.50.12](juspay/hyperswitch-web@v0.50.11...v0.50.12) (2024-05-10)

### Bug Fixes

* card brand configuration error added ([#362](juspay/hyperswitch-web#362)) ([f14c591](juspay/hyperswitch-web@f14c591))
@PritishBudhiraja PritishBudhiraja removed the Ready for Review PR with label Ready for Review should only be reviewed. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card network validation from PML Check card brand against PML eligible brands and throw an error on FE; disallow confirm
3 participants