refactor: register health endpoint alongside metrics server #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
approved these changes
May 21, 2025
inventvenkat
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
/healthendpoint alongside the metrics server, to allow it to be used as a readiness and liveness probe when deploying in Kubernetes environments. Currently, even though there exists a health endpoint, it is behind mTLS, which prevents it from being used as a readiness / liveness probe.Additionally, this PR addresses some clippy lints stabilized in Rust 1.87. This change affects the
src/app/tls.rsfile alone.I've also included some CI improvements in this PR.
I've tested it locally by calling the health endpoint at
http://localhost:6128/health.