Skip to content

chore: omp views redesign changes #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Dec 19, 2024
Merged

chore: omp views redesign changes #1894

merged 12 commits into from
Dec 19, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented Dec 9, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

image
image
image

Motivation and Context

How did you test it?

Where to test it?

  • INTEG
  • SANDBOX
  • PROD

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 self-assigned this Dec 9, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner December 9, 2024 13:21
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@gitanjli525 gitanjli525 linked an issue Dec 9, 2024 that may be closed by this pull request
[UI]: OMP Views redesign #1895
Closed
JeevaRamu0104
JeevaRamu0104 reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@JeevaRamu0104 JeevaRamu0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get it reviewed with Designer once

@Riddhiagrawal001
Copy link
Contributor

Screen.Recording.2024-12-16.at.11.39.16.AM.mov

@Riddhiagrawal001
Copy link
Contributor

Please check this screen as well
As earlier the views were applied for both users and roles
image

Riddhiagrawal001
Riddhiagrawal001 reviewed Dec 16, 2024
View reviewed changes
@gitanjli525
Copy link
Contributor Author

Please get it reviewed with Designer once

Reviewed with desginer

@gitanjli525
Copy link
Contributor Author

Please check this screen as well As earlier the views were applied for both users and roles image

We have applied views for both Users and Roles in the New Desgins as well

@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core labels Dec 17, 2024
@prajwalnl0 prajwalnl0 added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 2dfb19a Dec 19, 2024
5 of 6 checks passed
@prajwalnl0 prajwalnl0 deleted the omp-view-redesign branch December 19, 2024 11:36
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed core labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Riddhiagrawal001 Riddhiagrawal001 Riddhiagrawal001 approved these changes

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@kanikabansal-juspay kanikabansal-juspay Awaiting requested review from kanikabansal-juspay

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI]: OMP Views redesign
5 participants
@gitanjli525 @Riddhiagrawal001 @JeevaRamu0104 @kanikabansal-juspay @prajwalnl0