-
Notifications
You must be signed in to change notification settings - Fork 15
Bump to 0.15.0 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 0.15.0 #104
Conversation
@JohanMabille I'm out of my depth on this one. 😅 |
@blink1073 thanks for opening this, I totally forgot to update the wheel. I think you need to keep all the previous dependencies (including cppzmq and libzmq), and simply add the xeus-zmq package (between xeus and xeus-python); and of course bump the release versions of the xeus packages like you did. |
It seems like there's some more cmake magic to do. I tried mucking around locally with
|
That's weird, the cmake install files of xeus should be available, I will investigate over the week end |
OK got it, a check is missing in xeus-zmq CMakeLists.txt. Sorry for that, fixing it now. |
I added libuuid on Linux but it is still complaining about a missing
|
Theoretically we're supposed to dowload the source, build it and link xeus with the static lib of libuuid; that is what this part of the cmake is supposed to do. And I can see it installed in the logs, what I don't understand is why it does not find it when building xeus, this part has not changed since last release (or at least not in a visible way). |
I cannot reproduce locally, I need to setup a branch and instrument the cmake. |
It seems that the build is linking against a system-install libuuid instead of the one we build statically. |
I added an
|
957c3bf
to
c886c8b
Compare
To summarize:
The correct fix is to have EDIT: in the previous versions of xeus, this path was added by cppzmq, which is not a dependency of |
Sooooo we need a release of xeus ;) |
b331b47
to
de635bc
Compare
Nice work @JohanMabille! |
@blink1073 thanks! And thank you for upgrading the wheel and initiating the investigations! |
No description provided.