-
Notifications
You must be signed in to change notification settings - Fork 34
Add environments REST API #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidbrochart
wants to merge
1
commit into
jupyter-server:main
Choose a base branch
from
davidbrochart:kernelenv-creation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
from __future__ import annotations | ||
|
||
from abc import ABC, abstractmethod | ||
|
||
from fastapi import APIRouter, Depends | ||
|
||
from jupyverse_api import Router | ||
|
||
from ..app import App | ||
from ..auth import Auth, User | ||
from .models import CreateEnvironment, Environment, EnvironmentStatus | ||
|
||
|
||
class Environments(Router, ABC): | ||
def __init__(self, app: App, auth: Auth): | ||
super().__init__(app=app) | ||
|
||
router = APIRouter() | ||
|
||
@router.delete("/api/environments/{environment_id}", status_code=204) | ||
async def delete_environment( | ||
environment_id: str, | ||
user: User = Depends(auth.current_user(permissions={"sessions": ["write"]})), | ||
): | ||
return await self.delete_environment(environment_id, user) | ||
|
||
@router.post( | ||
"/api/environments", | ||
status_code=201, | ||
response_model=Environment, | ||
) | ||
async def create_environment( | ||
environment: CreateEnvironment, | ||
user: User = Depends(auth.current_user(permissions={"sessions": ["write"]})), | ||
) -> Environment: | ||
return await self.create_environment(environment, user) | ||
|
||
@router.get("/api/environments/wait/{environment_id}") | ||
async def wait_for_environment(environment_id: str) -> None: | ||
return await self.wait_for_environment(environment_id) | ||
|
||
@router.get("/api/environments/status/{environment_id}") | ||
async def get_status(id: str) -> EnvironmentStatus: | ||
return await self.get_status(id) | ||
|
||
self.include_router(router) | ||
|
||
@abstractmethod | ||
async def delete_environment( | ||
self, | ||
id: str, | ||
user: User, | ||
) -> None: ... | ||
|
||
@abstractmethod | ||
async def create_environment( | ||
self, | ||
environment: CreateEnvironment, | ||
user: User, | ||
) -> Environment: ... | ||
|
||
@abstractmethod | ||
async def wait_for_environment(self, id: str) -> None: ... | ||
|
||
@abstractmethod | ||
async def get_status(self, id: str) -> EnvironmentStatus: ... | ||
|
||
@abstractmethod | ||
async def run_in_environment(self, id: str, command: str) -> int: ... | ||
|
||
@abstractmethod | ||
def add_package_manager(self, name: str, package_manager: PackageManager): ... | ||
|
||
|
||
class PackageManager(ABC): | ||
@abstractmethod | ||
async def create_environment(self, environment_file_path: str) -> str: ... | ||
|
||
@abstractmethod | ||
async def delete_environment(self, id: str) -> None: ... | ||
|
||
@abstractmethod | ||
async def wait_for_environment(self, id: str) -> None: ... | ||
|
||
@abstractmethod | ||
async def get_status(self, id: str) -> EnvironmentStatus: ... | ||
|
||
@abstractmethod | ||
async def run_in_environment(self, id: str, command: str) -> int: ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
from __future__ import annotations | ||
|
||
from typing import Literal | ||
|
||
from pydantic import BaseModel | ||
|
||
EnvironmentStatus = ( | ||
Literal["package manager not found"] | ||
| Literal["environment uninitialized"] | ||
| Literal["environment creation start"] | ||
| Literal["environment creation success"] | ||
| Literal["environment creation error"] | ||
| Literal["environment file not found"] | ||
| Literal["environment file not readable"] | ||
) | ||
|
||
|
||
class CreateEnvironment(BaseModel): | ||
package_manager_name: str | ||
environment_file_path: str | ||
|
||
|
||
class Environment(BaseModel): | ||
id: str | ||
status: EnvironmentStatus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -251,4 +251,3 @@ class KernelsConfig(Config): | |
default=None, | ||
) | ||
require_yjs: bool = False | ||
kernelenv_path: str = "" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# Licensing terms | ||
|
||
This project is licensed under the terms of the Modified BSD License | ||
(also known as New or Revised or 3-Clause BSD), as follows: | ||
|
||
- Copyright (c) 2025-, Jupyter Development Team | ||
|
||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without | ||
modification, are permitted provided that the following conditions are met: | ||
|
||
Redistributions of source code must retain the above copyright notice, this | ||
list of conditions and the following disclaimer. | ||
|
||
Redistributions in binary form must reproduce the above copyright notice, this | ||
list of conditions and the following disclaimer in the documentation and/or | ||
other materials provided with the distribution. | ||
|
||
Neither the name of the Jupyter Development Team nor the names of its | ||
contributors may be used to endorse or promote products derived from this | ||
software without specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE | ||
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
||
## About the Jupyter Development Team | ||
|
||
The Jupyter Development Team is the set of all contributors to the Jupyter project. | ||
This includes all of the Jupyter subprojects. | ||
|
||
The core team that coordinates development on GitHub can be found here: | ||
https://github.com/jupyter/. | ||
|
||
## Our Copyright Policy | ||
|
||
Jupyter uses a shared copyright model. Each contributor maintains copyright | ||
over their contributions to Jupyter. But, it is important to note that these | ||
contributions are typically only changes to the repositories. Thus, the Jupyter | ||
source code, in its entirety is not the copyright of any single person or | ||
institution. Instead, it is the collective copyright of the entire Jupyter | ||
Development Team. If individual contributors want to maintain a record of what | ||
changes/contributions they have specific copyright on, they should indicate | ||
their copyright in the commit message of the change, when they commit the | ||
change to one of the Jupyter repositories. | ||
|
||
With this in mind, the following banner should be used in any source code file | ||
to indicate the copyright and license terms: | ||
|
||
# Copyright (c) Jupyter Development Team. | ||
# Distributed under the terms of the Modified BSD License. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# fps-environment-micromamba | ||
|
||
An FPS plugin for micromamba environments. |
6 changes: 6 additions & 0 deletions
6
plugins/environment_micromamba/fps_environment_micromamba/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import importlib.metadata | ||
|
||
try: | ||
__version__ = importlib.metadata.version("fps_environment_micromamba") | ||
except importlib.metadata.PackageNotFoundError: | ||
__version__ = "unknown" |
21 changes: 21 additions & 0 deletions
21
plugins/environment_micromamba/fps_environment_micromamba/main.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
from __future__ import annotations | ||
|
||
from anyio import Event, create_task_group | ||
from fps import Module | ||
|
||
from jupyverse_api.environments import Environments | ||
|
||
from .micromamba import Micromamba | ||
|
||
|
||
class EnvironmentMicromambaModule(Module): | ||
async def prepare(self) -> None: | ||
self.stop_event = Event() | ||
environments = await self.get(Environments) # type: ignore[type-abstract] | ||
async with create_task_group() as tg: | ||
environments.add_package_manager("micromamba", Micromamba(tg)) | ||
self.done() | ||
await self.stop_event.wait() | ||
|
||
async def stop(self) -> None: | ||
self.stop_event.set() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.