-
-
Notifications
You must be signed in to change notification settings - Fork 444
⬆️ Upgrade to react 18, latest @testing-library and migrate to vitest #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
// TODO: currently don't know how to simulate hydration of hooks. | ||
describe('useIsClient()', () => { | ||
it.skip('should be false when rendering on the server', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any help here would be appreciated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we haven't any clear direction about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, nice add, we will merge it when we'll be able to test both CSR and SSR. Thanks!
|
||
// TODO: currently don't know how to simulate hydration of hooks. | ||
describe('useIsClient()', () => { | ||
it.skip('should be false when rendering on the server', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, we haven't any clear direction about that
usehooks-ts changed since your PR, I rebased it to the latest master commit but I can't push it on your repo |
🦋 Changeset detectedLatest commit: b0002f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Someone is attempting to deploy a commit to a Personal Account owned by @juliencrn on Vercel. @juliencrn first needs to authorize it. |
Migrate away from deprecated testing-library/react-hooks
Had to skip one test in useIsClient since i couldn't figure out ssr and hydration yet.
- fix typo in useCopyToClipboard - improve useInterval speed using fake timer - remove noise by dropping tests on the depreciated interface of useCountdown
I will merge it finally, nothing happened for |
Thought I'd open a pr with what I had so far, in case anyone knows how to fix the last issue.
TODO: