Add next prev button in Docs-->Overview #1084
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
|
@RonakSurana-2001 pls. resolve the failing workflows |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
|
Maintainers can you please check now. |
| height={'15'} | ||
| width={'15'} |
There was a problem hiding this comment.
Let's not change this if not required.
There was a problem hiding this comment.
It's causing error/issue that why I changed please see
There was a problem hiding this comment.
Can you pls. attach a Screenshot of errors
|
@RonakSurana-2001 few points which I noticed to be done for much improved UI
|
|
Thanks for suggestions. Will try to complete asap. |
There was a problem hiding this comment.
Great job with this first iteration!
For now just implemented it for the overview section but we need to do it for all the sections: "getting started", "reference" and "specification".
Some additional comments:
- We need to add the component in the Code of Conduct TSX page.
- In the first page of the first section, the previous button won't do nothing. The target link is the same, the first page of the first section. Overview/What is JSON Schema.
- In the last page of each section the next button jumps to the first page of the next section. For example, in Code of Conduct, the next button will be overview page in Getting Started.
- In the last page of the last section, the next button will jump to the beginning, first page of first section : Overview/What is JSON Schema.
Great progress!!
|
Yes I will submit a PR by end of date. |
|
I have Made the required changes that you wanted in Docs-->Overview Kindly see |
|
I have added to Getting Started-->Examples please review that Also. |
|
Hi @RonakSurana-2001 . The buttons looks great in the overview section but we need more work to complete it in Getting Started. Let's not add the buttons in Reference and Specification for now so that we can merge this as soon as possible when it is complete. I recorded a quick video with me feedback. Hopefully this will help with the changes. pr-1084.mp4Please let me know your thoughts. |
|
Thank you @benjagm for a review. |
|
Congratulations, @RonakSurana-2001 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
I have created this PR to just verify that am I going in correct direction of solving the issue. Is this the thing that you wanted?
Does this PR introduce a breaking change?