Cyrillic support. #46
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should cover Russian, Ukrainian and Belarusian languages.
|
This is a small enough change that it doesn't seem to bloat the library too much. But, I'll need to draw the line somewhere. This PR seems like it's OK. In the future, maybe v2, it'll probably make sense to have language specific plugins. |
Conflicts: lib/string.js test/string.test.js
|
This merge request is outdated, but I still can open new one if necessary. |
|
Actually, I'm OK with this. Please submit a new one. Don't add anything to the |
|
@jprichardson OK, I will think how to make it fit suggestions described in #57. |
|
For people looking for this I recommend this: https://pid.github.io/speakingurl/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should cover Russian, Ukrainian and Belarusian languages. Related to #43.