Add NamedQueryer interfaces to avoid unnecessary Execer dependency #972
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NamedQuery funcs take Ext interface arguments which creates an unnecessary dependency on unused Execer methods. The newly added NamedQueryer interfaces narrow down the method set to only what is needed. This change should be backwards compatible since any type that would satisfy Ext also satisfies NamedQueryer.
ccoVeille
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NamedQueryfuncs takeExtinterface arguments which creates an unnecessary dependency on unusedExecermethods.The newly added
NamedQueryerinterfaces narrow down the method set to only what is needed. This change should be backwards compatible since any type that would satisfyExtalso satisfies the subsetNamedQueryer.My motivating use case is a "read only" connection (to a read replica of a DB cluster), which implements
Queryerbut notExecer, should be usable with theNamedQueryfuncs.