Skip to content

Conversation

mmorel-35
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • enable badLock from go-critic

How was this change tested?

Checklist

@mmorel-35 mmorel-35 marked this pull request as ready for review August 12, 2025 06:38
@mmorel-35 mmorel-35 requested a review from a team as a code owner August 12, 2025 06:38
@mmorel-35 mmorel-35 requested a review from albertteoh August 12, 2025 06:38
@dosubot dosubot bot added the go Pull requests that update go code label Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.46%. Comparing base (022a5ea) to head (181fba0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7437   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         377      377           
  Lines       23090    23090           
=======================================
  Hits        22274    22274           
  Misses        618      618           
  Partials      198      198           
Flag Coverage Δ
badger_v1 9.02% <ø> (ø)
badger_v2 1.70% <ø> (ø)
cassandra-4.x-v1-manual 11.68% <ø> (ø)
cassandra-4.x-v2-auto 1.69% <ø> (ø)
cassandra-4.x-v2-manual 1.69% <ø> (ø)
cassandra-5.x-v1-manual 11.68% <ø> (ø)
cassandra-5.x-v2-auto 1.69% <ø> (ø)
cassandra-5.x-v2-manual 1.69% <ø> (ø)
elasticsearch-6.x-v1 16.58% <ø> (ø)
elasticsearch-7.x-v1 16.63% <ø> (ø)
elasticsearch-8.x-v1 16.77% <ø> (ø)
elasticsearch-8.x-v2 1.70% <ø> (ø)
elasticsearch-9.x-v2 1.70% <ø> (ø)
grpc_v1 10.21% <ø> (ø)
grpc_v2 1.70% <ø> (ø)
kafka-3.x-v1 9.68% <ø> (ø)
kafka-3.x-v2 1.70% <ø> (ø)
memory_v2 1.70% <ø> (ø)
opensearch-1.x-v1 16.67% <ø> (ø)
opensearch-2.x-v1 16.67% <ø> (ø)
opensearch-2.x-v2 1.70% <ø> (ø)
opensearch-3.x-v2 1.70% <ø> (ø)
query 1.70% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal code refactoring without functional changes label Aug 12, 2025
@yurishkuro yurishkuro enabled auto-merge August 12, 2025 12:13
@yurishkuro yurishkuro added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 12, 2025
@yurishkuro yurishkuro merged commit b11cced into jaegertracing:main Aug 12, 2025
86 of 89 checks passed
@mmorel-35 mmorel-35 deleted the gocritic/badLock branch August 12, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:refactoring Internal code refactoring without functional changes go Pull requests that update go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants