Fixes errors in manipulation envs #3418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm still seeing some issues in the environment tests - Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0 has an error |
… API and bug in add_reference_to_stage - from Y-up to Z-up - scales applied to child xform prim
…707/IsaacLab into reb/fix_manip_envs
github-actions
bot
added
bug
|
@kellyguo11 I have fixed the usd assets which I have tested can pass the pytests. And updated here: box and toytruck. Could you help to move them to isaac-dev nucleus folder? Many thanks. |
kellyguo11
added a commit
that referenced
this pull request
Sep 18, 2025
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> The CI tests met asset errors and controller errors for below envs: - "Isaac-Stack-Cube-Instance-Randomize-Franka-IK-Rel-v0", - "Isaac-Stack-Cube-Instance-Randomize-Franka-v0", - "Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0", - "Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0" ## Fixes - Add missing gripper configs in Stack TaskEnvCfgs: self.gripper_joint_names = ["panda_finger_.*"] self.gripper_open_val = 0.04 self.gripper_threshold = 0.005 - Move all object assets in Agibot tasks to S3 bucket. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Kelly Guo <[email protected]>
ooctipus
pushed a commit
to ooctipus/IsaacLab
that referenced
this pull request
Sep 20, 2025
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> The CI tests met asset errors and controller errors for below envs: - "Isaac-Stack-Cube-Instance-Randomize-Franka-IK-Rel-v0", - "Isaac-Stack-Cube-Instance-Randomize-Franka-v0", - "Isaac-Place-Mug-Agibot-Left-Arm-RmpFlow-v0", - "Isaac-Place-Toy2Box-Agibot-Right-Arm-RmpFlow-v0" ## Fixes - Add missing gripper configs in Stack TaskEnvCfgs: self.gripper_joint_names = ["panda_finger_.*"] self.gripper_open_val = 0.04 self.gripper_threshold = 0.005 - Move all object assets in Agibot tasks to S3 bucket. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste that source into the above before/after sections. --> ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Kelly Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CI tests met asset errors and controller errors for below envs:
Fixes
Add missing gripper configs in Stack TaskEnvCfgs:
self.gripper_joint_names = ["panda_finger_.*"]
self.gripper_open_val = 0.04
self.gripper_threshold = 0.005
Move all object assets in Agibot tasks to S3 bucket.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there