Fixes memory leak in video recorder

[pascal-roth]

Description

gymanisum still doesn't clear the video frames correclty, this PR replaces the gymnasium video wrapper in the scripts until Farama-Foundation/Gymnasium#1444 is merged

Type of change

• Bug fix (non-breaking change which fixes an issue)

Screenshots

Before	After

|

|

|

Checklist

• I have run the pre-commit checks with ./isaaclab.sh --format
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• I have updated the changelog and the corresponding version in the extension's config/extension.toml file
• I have added my name to the CONTRIBUTORS.md or my name already exists there

[Mayankm96]

Should we just upgrade gymnasium to latest?

[pascal-roth]

it is not done in latest, made a PR in gymnasium

[ooctipus]

for this purpose I think there is another style called duck-patching that can offer cleaner solution (less file edit).

[pascal-roth]

@ooctipus I didn't know about that one, can change it

[Mayankm96]

We can make our own fork of gymnasium where we put these fixes. Similar to how we handle rl-games? Wouldn't modify our source code to handle this class. Removing the class later then becomes an issue for compatibility.

[pascal-roth]

I think that is where @ooctipus suggestions comes in, just updating the code for it

[pascal-roth]

@Mayankm96 this change should now ensure that we dont have compatibility issues later

[timote-MOREAUX]

I traced the issue few months ago and optimally the patch needs to be done in MoviePy package (see Zulko/moviepy#2437) there is an issue in its implementation. I opened an issue there and it should be corrected by now on the main branch Zulko/moviepy#2459 but no new version was released yet. I didn't test the patch but the frames should be collected automatically and no specific changes in gymnasium will be needed other than updating MoviePy later on.

[Mayankm96]

I still feel making our own fork of Gymnasium and having a fix there is a cleaner solution than modifying code at multiple places. Later once the patch on Gymnasium or moviepy is addressed, we can simply change the Gymnasium (and its dependencies) downloaded.

The current solution fixes things on the IsaacLab repo side, but all scripts users have on theri extension template repo will still be affected.

[pascal-roth]

@timote-MOREAUX great! then this should fix it. Still we should avoid that memory leak for users early on without waiting for another release.

@Mayankm96 make sense from that perspective, I can make a fork of gymnasium and implement the fix there

[Mayankm96]

@pascal-roth Let's try to get this in for 2.3 release?

[pascal-roth]

@Mayankm96 can u make the fork, I am missing the permission