fix(linux): electron 35 to fix GTK error #2953
Merged
+46
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
downgrading electron until it is "safe" to use GTK4 as the new default.
this feels safer than hardcoding
app.commandLine.appendSwitch('gtk-version', '3')
in our code.
Closes #2952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is downgrading electron to 35.x until it is "safe" to use GTK4 as the new default.
It also adds entry to FAQ in case someone updates it before it gets fixed, and/or error hits users in the future.
Closes #2952
Rationale
This feels safer than hardcoding
in our code, or asking people to "self-fix" broken app by passing
--gtk-version.Both are very bad UX and brittle long term.