Skip to content

bump ts to v5 #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 10, 2023
Merged

bump ts to v5 #2289

merged 7 commits into from
Dec 10, 2023

Conversation

foxriver76
Copy link
Collaborator

@foxriver76 foxriver76 commented Jun 12, 2023 •
edited
Loading

but not to 5.1.3 yet, as it does not resolve the types for the monorepo correctly, as stated in various places like microsoft/TypeScript#51715 (comment)

Maybe it will be fixed soon.

microsoft/TypeScript#54515

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2023
View reviewed changes
packages/common/src/lib/common/aliasProcessing.ts
`${prefix}Type`,
`${prefix}Min`,
`${prefix}Max`,
`return ${transformer}`

Check warning

Code scanning / CodeQL

Unsafe code constructed from library input

This string concatenation which depends on [library input](1) is later [interpreted as code](2). This string concatenation which depends on [library input](3) is later [interpreted as code](2). This string concatenation which depends on [library input](4) is later [interpreted as code](2). This string concatenation which depends on [library input](5) is later [interpreted as code](2). This string concatenation which depends on [library input](6) is later [interpreted as code](2). This string concatenation which depends on [library input](7) is later [interpreted as code](2). This string concatenation which depends on [library input](8) is later [interpreted as code](2). This string concatenation which depends on [library input](9) is later [interpreted as code](2). This string concatenation which depends on [library input](10) is later [interpreted as code](2). This string concatenation which depends on [library input](11) is later [interpreted as code](2). This string concatenation which depends on [library input](12) is later [interpreted as code](2). This string concatenation which depends on [library input](13) is later [interpreted as code](2). This string concatenation which depends on [library input](14) is later [interpreted as code](2).
@foxriver76 foxriver76 merged commit 8d76d86 into master Dec 10, 2023
@foxriver76 foxriver76 deleted the ts-5 branch December 10, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollon77 Apollon77 Apollon77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foxriver76 @Apollon77