[ESIMD][NFC] Extract ESIMD handling from sycl-post-link to library. #18684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit. The documentation of lowerESIMDConstructs are fixed and the argument name is changed to more straightforward.
sarnex
approved these changes
May 27, 2025
asudarsa
reviewed
May 27, 2025
asudarsa
approved these changes
May 27, 2025
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Speaking of the testing, different parts are being tested by LIT tests by |
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
approved these changes
Jun 16, 2025
|
Hi @maksimsab |
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maksimsab
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please consider merging |
|
@maksimsab is this actually ready for merge? |
|
@intel/llvm-gatekeepers please consider merging |
|
@maksimsab x2 is this actually ready for merge? |
|
@sarnex thanks for pointing out! @intel/llvm-gatekeepers Can we merge this please? |
Maetveis
added a commit
to Maetveis/llvm
that referenced
this pull request
Sep 22, 2025
Starting from intel#18684 in debug/release with asserts builds entry points are always dumped in ESIMDPostSplitProcessing. This is meant to be a debugging tool, but now it is spamming build logs. intel#18684 is marked as NFC, so my assumption is that this was unintentional. Guard the dump with a variable (disabled by default) so that it can be enabled for debugging, the same way as it was in sycl-post-link.cpp prior to the code move. FYI: `LLVM_ENABLE_DUMP` is an option documented to > Enable dump functions even when assertions are disabled (from [llvm/CMakeLists.txt:698](https://github.com/llvm/llvm-project/blob/32b1f167fbee28debc7527b939a6764575c854a4/llvm/CMakeLists.txt#L698)) and its typical usage is to guard the definitions of dump functions, e.g.: ```cpp LLVM_DUMP_METHOD void dump() const; ``` and not to guard **calls** to such functions.
Maetveis
added a commit
to Maetveis/llvm
that referenced
this pull request
Sep 22, 2025
Starting from intel#18684 in debug/release with asserts builds entry points are always dumped in ESIMDPostSplitProcessing. This is meant to be a debugging tool, but now it is spamming build logs. intel#18684 is marked as NFC, so my assumption is that this was unintentional. Guard the dump with a variable (disabled by default) so that it can be enabled for debugging, the same way as it was in sycl-post-link.cpp prior to the code move. FYI: `LLVM_ENABLE_DUMP` is an option documented to > Enable dump functions even when assertions are disabled (from [llvm/CMakeLists.txt:698](https://github.com/llvm/llvm-project/blob/32b1f167fbee28debc7527b939a6764575c854a4/llvm/CMakeLists.txt#L698)) and its typical usage is to guard the definitions of dump functions, e.g.: ```cpp class Foo { // ... void dump() const; } ``` and not to guard **calls** to such functions.
sarnex
pushed a commit
that referenced
this pull request
Sep 24, 2025
…20150) Starting from #18684 in debug/release with asserts builds entry points are always dumped in ESIMDPostSplitProcessing. This is meant to be a debugging tool, but now it is spamming build logs. #18684 is marked as NFC, so my assumption is that this was unintentional. Guard the dump with a variable (disabled by default) so that it can be enabled for debugging, the same way as it was in sycl-post-link.cpp prior to the code move. FYI: `LLVM_ENABLE_DUMP` is an option documented to > Enable dump functions even when assertions are disabled (from [llvm/CMakeLists.txt:698](https://github.com/llvm/llvm-project/blob/32b1f167fbee28debc7527b939a6764575c854a4/llvm/CMakeLists.txt#L698)) and its typical usage is to guard the definitions of dump functions, e.g.: ```cpp class Foo { // ... #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) void dump() const; #endif } ``` and not to guard **calls** to such functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts handleESIMD from sycl-post-link to SYCLPostLink component for reuse in NewOffloading compilation flow in clang and for reuse in sycl-jit.
The body of
handleESIMDfunction is refactored for better readability.The documentation of lowerESIMDConstructs is fixed and the argument name is changed to more straightforward.