Skip to content

Support repository and deployment URL of GHES #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support repository and deployment URL of GHES #878

wants to merge 1 commit into from

Conversation

int128
Copy link
Owner

@int128 int128 commented Feb 18, 2023 •
edited
Loading

@int128 int128 marked this pull request as ready for review February 18, 2023 12:36
@int128 int128 mentioned this pull request Feb 18, 2023
Open
@github-actions github-actions bot deployed to pr-878/app1 February 18, 2023 12:40 Active
This was referenced Feb 18, 2023
Merged
Merged
Merged
@Oded-B
Copy link

Oded-B commented Jul 26, 2023 •
edited
Loading

Any chance we can get this merged?

I just wrote an identical PR because I missed this one :)

I had to add /api/v3 to the newOAuth2Client BaseURL to get it to work with my instace:
https://github.com/Oded-B/argocd-commenter/pull/1/files

The /api/v3 path is automatically added to the "regular" REST calls so the GITHUB_ENTERPRISE_URL doesn't need to include it, maybe it would make more sense to add this logic to https://github.com/int128/oauth2-github-app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@int128 @Oded-B