Skip to content

link/unlink refinement take 3 #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2025
Merged

link/unlink refinement take 3 #1641

merged 2 commits into from
Sep 16, 2025

Conversation

tonsky
Copy link
Contributor

@tonsky tonsky commented Sep 10, 2025

  • Removed newData.ref (it wasn’t really working because it feels like it should run on the new version of the DB but in fact it runs on the old one)

@github-actions GitHub Actions
Copy link
Contributor

View Vercel preview at instant-www-js-link-unlink-3-jsv.vercel.app.

stopachka
stopachka approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@stopachka stopachka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit by bit!

@tonsky tonsky force-pushed the link-unlink-3 branch 2 times, most recently from 273e1cf to cfefae0 Compare September 16, 2025 18:54
@tonsky
Copy link
Contributor Author

tonsky commented Sep 16, 2025

Also added:

  • Allow specifying ruleParams on either side of the link (from @stopachka friction log)

@tonsky tonsky merged commit de9f106 into main Sep 16, 2025
27 checks passed
@tonsky tonsky deleted the link-unlink-3 branch September 16, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopachka stopachka stopachka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonsky @stopachka