This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Byron chain download uses better checkpoints #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avieth
force-pushed
the
avieth/chain_download_checkpoints
branch
from
7083cb6 to
9c4e8e0
Compare
coot
reviewed
Sep 2, 2019
| -- is not constant over a whole blockchain: it can be changed by an update. | ||
| -- However, in cardano-byron-proxy it is only used to determine message | ||
| -- size limits on Byron protocols, so as long as header, block, and tx | ||
| -- size limits do not change, it's ok. |
There was a problem hiding this comment.
It might be good to add this to top level description of byron-proxy, e.g. README.md or a wiki page, if devops should be awere of this.
the cardano-byron-proxy only needs to relay transactions. All other atomic (non-block) data can be ignored.
Also corrected the download loop to work even if the peer does not support streaming: the hash of the last block downloaded is retained and used at the next loop.
Somebody decided to stylish-haskell the imports and it was a mess
avieth
force-pushed
the
avieth/chain_download_checkpoints
branch
from
9c4e8e0 to
e17fa24
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 2, 2019
27: Byron chain download uses better checkpoints r=avieth a=avieth Previously it would use only one checkpoint: the current tip. That's fine if there are no forks, but wouldn't work if there were. Now the checkpoints are computed in the same way as the chain sync client from ouroboros-consensus: fibonacci numbers including `0` and `k` without the duplicate `1`. I've also included some unrelated improvements to documentation, and a commit to make configuring the Byron-side easier (using cardano-sl configurations). Co-authored-by: Alexander Vieth <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would use only one checkpoint: the current tip. That's fine if there are no forks, but wouldn't work if there were.
Now the checkpoints are computed in the same way as the chain sync client from ouroboros-consensus: fibonacci numbers including
0andkwithout the duplicate1.I've also included some unrelated improvements to documentation, and a commit to make configuring the Byron-side easier (using cardano-sl configurations).