Skip to content

Conversation

Aariyan007
Copy link

@Aariyan007 Aariyan007 commented Sep 10, 2025

What does this PR do?

This PR resolves Spotless code formatting violations that were causing Maven build failures in the twin module.

Fixes #3303

Changes made:

  • Restored required imports for ArgumentMatchers.any and ArgumentMatchers.eq that are used in the testInterrupt() method
  • Fixed import ordering to follow alphabetical convention as enforced by Spotless
  • Added proper spacing between import statements and class declaration
  • Removed commented-out import statements to clean up the code

Root cause:
The original issue was caused by unused imports that were commented out, but the code still referenced eq() and any() methods in the test. This created a mismatch between what was imported and what was actually used, triggering Spotless formatting violations.

Testing:

This change ensures the codebase maintains consistent formatting standards while preserving all test functionality.

fix: resolve Spotless formatting violations in BallThreadTest

- Restore required imports for ArgumentMatchers.any and eq
- Fix import ordering to follow alphabetical convention
- Add proper spacing between imports and class declaration
- Remove commented-out import statements

Fixes Maven build failure caused by spotless:check violations.
Copy link

github-actions bot commented Sep 10, 2025

PR Summary

This PR fixes Spotless code formatting violations in the BallThreadTest.java file, resolving a Maven build failure. The changes include restoring required imports, fixing import ordering, adding spacing between imports and the class declaration, and removing commented-out imports.

Changes

File Summary
twin/src/test/java/com/iluwatar/twin/BallThreadTest.java Fixed Spotless code formatting violations. Restored imports for ArgumentMatchers.any and ArgumentMatchers.eq. Fixed import order and spacing. Removed commented-out imports.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 2f7eb7b: Update BallThreadTest.java

fix: resolve Spotless formatting violations in BallThreadTest

  • Restore required imports for ArgumentMatchers.any and eq
  • Fix import ordering to follow alphabetical convention
  • Add proper spacing between imports and class declaration
  • Remove commented-out import statements

Fixes Maven build failure caused by spotless:check violations.

Files Processed (1)
  • twin/src/test/java/com/iluwatar/twin/BallThreadTest.java (3 hunks)
Actionable Comments (0)
Skipped Comments (0)

Copy link

@Aariyan007
Copy link
Author

The original issue was caused by unused imports that were commented out, but the code still referenced eq() and any() methods in the test. This created a mismatch between what was imported and what was actually used, triggering Spotless formatting violations. Now its Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant