bean names should not be meaningful

[egh]

It seems that it is not a good idea to use the bean name in spring to provide configuration. This is an issue with accesspoints: the configuration,

<bean name="8080:wayback" class="org.archive.wayback.webapp.AccessPoint">

means, I believe, that the accesspoint should use port 8080 and the path /wayback/. The bean name should not have any bearing on the configuration of the access point.

[ikreymer]

Yeah, this is an older usage, but not removed for backwards compatibility.
There are newer properties, demonstrated in the sample overlay example, which, if present override the bean name to specify port and path

 <bean name="accessPoint" class="org.archive.wayback.webapp.AccessPoint">
    <property name="accessPointPath" value="${wayback.path}"/>
    <property name="internalPort" value="${wayback.port}"/>
    ...

The bean name is thus ignored and accessPointPath is the path and internalPort is the port

[egh]

Thanks for the pointer, Ilya. So all we need to change is the documentation and the examples.

The default accessPoint configuration specified in the wayback.xml bundled with 2.0.0 beta 1 doesn't work unless ":wayback" is removed from the bean name or "wayback/" is appended to the values of the replayPrefix, queryPrefix, staticPrefix, and replayURIPrefix properties. Recommend standardizing one way or the other.

[egh]

What I would like to do is give the beans in the example configuration names which cannot be interpreted as port:prefix combinations so that these issues are caught quickly. I will submit a pull request.

[kris-sigur]

In addition to what's in Erik's pull request, I'd suggest we have Wayback emit a deprecated warning to the log when it encounters these "meaningful" bean names.

[egh]

Example configs and documentation have been changed. Closing this ticket.