Query string being stripped from Memento queries.

[anjackson]

Following the Memento bug reported in this thread on openwayback-dev, we should attempt @ikreymer's fix:

I think the issue is due to this block here:

https://github.com/iipc/openwayback/blob/master/wayback-core/src/main/java/org/archive/wayback/memento/TimeMapRequestParser.java#L62

My guess now is it was added by mistake, as it clearly strips the query from the request url every time.. (it may have been something to do with cdx server support).

I would recommend removing this block and testing to see if this fixes the problem.

[anjackson]

Okay, so this is fairly serious, and is giving Wikipedians' some headaches. But, I'm not sure how to proceed - should we do more testing now, or assume this will work and roll a BETA.2 release?

@nlevitt - what do IA need in order to deploy this fix?

@mementoweb - are you able to do any testing?

I tested with limited set of warc files I found at openwayback github.
I noticed that test warc files only have one memento per url. May be we need some sample files with multiples mementos to test timemaps and cdx server api.

---

From: Andy Jackson [notifications@github.com]
Sent: Wednesday, April 02, 2014 10:02 AM
To: iipc/openwayback
Cc: Balakireva, Lyudmila
Subject: Re: [openwayback] Query string being stripped from Memento queries. (#106)

Okay, so this is fairly serious, and is giving Wikipedians' some headacheshttps://en.wikipedia.org/wiki/Wikipedia_talk:Link_rot#Mementos_-_cross-archive_searching. But, I'm not sure how to proceed - should we do more testing now, or assume this will work and roll a BETA.2 release?

@nlevitthttps://github.com/nlevitt - what do IA need in order to deploy this fix?

@mementowebhttps://github.com/mementoweb - are you able to do any testing?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/106#issuecomment-39348670.

[nlevitt]

Made pull request for IA wayback internetarchive#17

[anjackson]

Tested at IA, all good.