refactor: split the Header trait into three traits
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Header` trait is now `Named`, `Decodable` and `Encodable`. The goal of this change is to make it possible to implement `Encodable` for borrowed types. Under the existing code, `Header::decode()` requires that `Self` own its data. But it is a legitimate use to do `Header::encode()` on borrowed data. By separating the traits, we can implement `Encodable` on borrowed types and `Encodable` and `Decodable` on owned types. Signed-off-by: Nathaniel McCallum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Headertrait is nowNamed,DecodableandEncodable.The goal of this change is to make it possible to implement
Encodablefor borrowed types. Under the existing code,
Header::decode()requiresthat
Selfown its data. But it is a legitimate use to doHeader::encode()on borrowed data. By separating the traits, we canimplement
Encodableon borrowed types andEncodableandDecodableon owned types.
Signed-off-by: Nathaniel McCallum [email protected]