Fix intel-mkl-src
dependency and use static-linking
in Dockerfile
#715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
intel-mkl-src
dependency by adding the missingdep:intel-mkl-src
within themkl
feature intext-embeddings-router
, without it theintel-mkl-src
dependency was unresolved hence the conditional features beingstatic-linking
anddynamic-linking
had no target to install those features for, and those were silently ignored.All that was leading to the
intel-mkl-src
to come without any of the linking types leading to all the issues recently reported on both Intel and AMD when running CPU inference without ONNX as e.g. "Intel oneMKL ERROR: Parameter 13 was incorrect on entry to SGEMM".Fixes: #706, #636, #667, #680; and potentially also fixes #237. Additionally, it also "fixes" huggingface/candle#3018 i.e., a Text Embeddings Inference issue reported on
candle
instead.Before submitting
insta
snapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Narsil