Skip to content

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR fixes the intel-mkl-src dependency by adding the missing dep:intel-mkl-src within the mkl feature in text-embeddings-router, without it the intel-mkl-src dependency was unresolved hence the conditional features being static-linking and dynamic-linking had no target to install those features for, and those were silently ignored.

All that was leading to the intel-mkl-src to come without any of the linking types leading to all the issues recently reported on both Intel and AMD when running CPU inference without ONNX as e.g. "Intel oneMKL ERROR: Parameter 13 was incorrect on entry to SGEMM".

Fixes: #706, #636, #667, #680; and potentially also fixes #237. Additionally, it also "fixes" huggingface/candle#3018 i.e., a Text Embeddings Inference issue reported on candle instead.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines.
  • Did you write any new necessary tests? If applicable, did you include or update the insta snapshots?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil

@alvarobartt alvarobartt requested a review from Narsil September 8, 2025 18:13
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants