Skip to content

Conversation

sayakpaul
Copy link
Member

What does this PR do?

This PR adds a section to the PixArt Alpha docs about how to perform inference in 8bit so that the GPU memory requirements are kept under 8GB.

Cc: @lawrence-cj

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!


</Tip>

## Running the `PixArtAlphaPipeline` in under 8GB GPU VRAM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put this content into a Tips section (like how it is here) so it is more aligned with the other model API docs. I think this'll improve the docs experience since all the pages will be consistent and users know what to expect if they're going from one page to the next

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this section is a good candidate to be put as a tip, though. Taking this as an example, I see all the points as advice (or tips). They very well align with what's supposed to be a tip. But I don't think execution under constrained environments can be a tip.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, maybe we can put it in a Usage section then? I think it's better to have something more generalizable to keep the pages consistent (like DeepFloyd IF or Pix2Pix).

@sayakpaul
Copy link
Member Author

@stevhliu added a note on 4bit inference in 1265b9d.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 17, 2023

The documentation is not available anymore as the PR was closed or merged.

@sayakpaul
Copy link
Member Author

@stevhliu I have addressed your comments in 29674b6. I feel good about how the docs are as is right now. Feel free to propose changes in a follow-up PR.

Going to merge once the CI is green.

@sayakpaul sayakpaul merged commit e5f232f into main Nov 24, 2023
@sayakpaul sayakpaul deleted the docs/8bit-inference-pixart branch November 24, 2023 15:06
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
* add: 8bit inference with pixart alpha

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* add: note on 4bit.

* Apply suggestions from code review

Co-authored-by: Steven Liu <[email protected]>

* address comment

---------

Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants