chore(r/query_annotation): migrate to Plugin Framework #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewkrupa
reviewed
Aug 22, 2025
| Attributes: map[string]schema.Attribute{ | ||
| "id": schema.StringAttribute{ | ||
| Description: "The unique identifier for this Query Annotation.", | ||
| Computed: true, |
There was a problem hiding this comment.
q - looks like the ApiKeyResource
terraform-provider-honeycombio/internal/provider/api_key_resource.go
Lines 70 to 71 in 448e063
specifies Required: false and Optional: false for id. I guess those are zero values so they default to false, but should we include them for clarity?
There was a problem hiding this comment.
Sure! clarity is nice
| return | ||
| } | ||
|
|
||
| dataset := state.Dataset.ValueString() |
There was a problem hiding this comment.
should this use helper.GetDatasetOrAll like the rest of the methods here?
There was a problem hiding this comment.
Oops! I missed that. Fixed.
cewkrupa
approved these changes
Aug 22, 2025
jharley
added a commit
that referenced
this pull request
Aug 25, 2025
Fixes the follow error if `description` was empty: > Error: Provider produced inconsistent result after apply When applying changes to honeycombio_query_annotation.nice, provider "provider[\"[registry.terraform.io/honeycombio/honeycombio](http://registry.terraform.io/honeycombio/honeycombio)\"]" produced an unexpected new value: .description: was null, but now cty.StringVal(""). This is a bug in the provider, which should be reported in the provider's own issue tracker. - Introduced by #744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates
r/query_annotationto the Plugin Framework.