Skip to content

Conversation

danquack
Copy link

@danquack danquack commented Mar 18, 2025

Description

Add support for setting subscribe_event_types on vault policy data source.

Closes #2380
Relates #2293

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ TF_ACC=1 go test -v -count=1 -run 'TestDataSourcePolicyDocument' ./vault/...
=== RUN   TestDataSourcePolicyDocument
--- PASS: TestDataSourcePolicyDocument (0.83s)
=== RUN   TestDataSourcePolicyDocument_withSubscribeEvents
--- PASS: TestDataSourcePolicyDocument_withSubscribeEvents (0.65s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     1.964s
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@danquack danquack requested a review from a team as a code owner March 18, 2025 14:51
@danquack danquack requested a review from ldilalla-HC March 18, 2025 14:51
@danquack danquack changed the title ✨ support for subscribe_event_types ✨ d/vault_policy_document - support for subscribe_event_types Mar 18, 2025
@danquack
Copy link
Author

Doesn't look like this project uses go changelog, should I just update the README directly for the changelog?

@drewmullen
Copy link
Contributor

Try adding your changelog entry similar to this commit: hashicorp/vault-plugin-secrets-terraform@b7ac127

Copy link
Contributor

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests pass 👍

TF_ACC=1 go test -v -count=1 -run 'TestDataSourcePolicyDocument' ./vault/...
=== RUN   TestDataSourcePolicyDocument
--- PASS: TestDataSourcePolicyDocument (0.80s)
=== RUN   TestDataSourcePolicyDocument_withSubscribeEvents
--- PASS: TestDataSourcePolicyDocument_withSubscribeEvents (0.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	2.175s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Support event subscriptions in vault_policy_document data source
2 participants