Simplify actions to one schema type #1220
Merged
+322
−423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBGoods
commented
Sep 15, 2025
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/google/go-cmp v0.7.0 | ||
| github.com/hashicorp/terraform-plugin-go v0.29.0-beta.1.0.20250904144425-4c19f069077d | ||
| github.com/hashicorp/terraform-plugin-go v0.29.0-beta.1.0.20250915191812-03e996589dc2 |
There was a problem hiding this comment.
Todo: update to next terraform-plugin-go release
austinvalle
reviewed
Sep 15, 2025
There was a problem hiding this comment.
Looking good! There are a couple comments still referencing linked resources or other action schema types:
action.ActioninterfaceInvokemethodaction.ActionWithModifyPlaninterfaceModifyPlanmethod- TODOs that still reference linked resources (looking at
TODO:Actionsin fromproto + toproto)
Also looks like the golang lint CI caught a couple things + one build error in the toproto6 test package: https://github.com/hashicorp/terraform-plugin-framework/actions/runs/17746458126/job/50432665327?pr=1220
go.mod
Outdated
| @@ -2,19 +2,19 @@ module github.com/hashicorp/terraform-plugin-framework | |||
|
|
|||
| go 1.24.0 | |||
|
|
|||
| toolchain go1.24.4 | |||
| toolchain go1.24.2 | |||
There was a problem hiding this comment.
Gotta update that local Go version 😆
5 tasks
austinvalle
approved these changes
Sep 16, 2025
SBGoods
force-pushed
the
SBGoods/simplify-actions
branch
from
ea3fb1a to
b73519f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hashicorp/terraform-plugin-go#559
Removes other action schema types and references to linked resources