Skip to content

Conversation

stephenmcconkey
Copy link
Contributor

@stephenmcconkey stephenmcconkey commented Jun 23, 2022

What
Evaluator logs where not respecting the custom logger
Also changed some info logs to debug to reduce clutter

FFM-3702

Why
This is because the custom logger wasn't being passed in, and therefore the default logger was always being used

Testing
Manually tested
Unit Tests - because I added this to the evaluator struct, I had to make a nooplogger

@swarmia
Copy link

swarmia bot commented Jun 23, 2022

✅  Linked to Bug FFM-3702 · Go FF SDK not Respecting Custom Logger

Copy link
Contributor

@enver-bisevac enver-bisevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, what about other packages like cache, repository still using global log? Maybe it should go in another ticket?

Copy link
Contributor

@conormurray95 conormurray95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Like Enver said there might be a few stragglers that use the global log on startup but this removes all the noisy ones the customer was complaining about for now

@stephenmcconkey stephenmcconkey merged commit b3128e7 into main Jun 23, 2022
@erdirowlands erdirowlands deleted the FFM-3702 branch November 3, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants