Skip to content

[FFM-1415] added UT to reproduce bug FFM-1415 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

[FFM-1415] added UT to reproduce bug FFM-1415 #81

merged 1 commit into from
May 9, 2022

Conversation

enver-bisevac
Copy link
Contributor

  • UT added
  • Cleanup the code in GetVariationName

@swarmia
Copy link

swarmia bot commented May 9, 2022

✅  Linked to Bug FFM-1415 · FF Client Service - The segment in variation map is invalid

davejohnston
davejohnston approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@davejohnston davejohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enver-bisevac enver-bisevac merged commit 25509a7 into main May 9, 2022
@enver-bisevac enver-bisevac deleted the FFM-1415 branch May 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Hayes Andrew-Hayes Awaiting requested review from Andrew-Hayes

@jcox250 jcox250 Awaiting requested review from jcox250

@conormurray95 conormurray95 Awaiting requested review from conormurray95

1 more reviewer

@davejohnston davejohnston davejohnston approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enver-bisevac @davejohnston