Skip to content

Conversation

davejohnston
Copy link
Contributor

@davejohnston davejohnston commented Apr 27, 2021

If a flag has pre-requisistes then they should be evaluated before returning the
flag. If a pre-req is not met, then we return the offVariation for the flag.

In order to make this more testable, the persistence store can be disabled, and the http client used in API requests can be overwritten.

Dave Johnston added 2 commits April 27, 2021 16:11
If a flag has pre-requisistes then they should be evaluated before returning the
flag.  If a pre-req is not met, then we return the offVariation for the flag.
Copy link
Contributor

@Andrew-Hayes Andrew-Hayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davejohnston davejohnston merged commit dde32d6 into harness:main Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants