[FFM-1355]: SDK doesn't support multiple custom attributes and name no… #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2021 19:35
…t set correctly The Target builder replaces the attributes map with every new custom attribute. This means we only ever could have one custom attribute. Name was stored as a custom attribute instead of as a named field, the problem is if you have the Java SDK using the same target, then it sends 'name' as a named field, and so conflicts with custom attributes. This PR fixes the issue with the custom attributes and ensures name is stored in a named field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t set correctly
The Target builder replaces the attributes map with every new custom attribute. This means
we only ever could have one custom attribute.
Name was stored as a custom attribute instead of as a named field, the problem is if you have
the Java SDK using the same target, then it sends 'name' as a named field, and so conflicts with
custom attributes.
This PR fixes the issue with the custom attributes and ensures name is stored in a named field.