Skip to content

(FFM-1290) Ignored empty evaliation attibute #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2021
Merged

(FFM-1290) Ignored empty evaliation attibute #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions evaluation/target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ func (t Target) GetAttrValue(attr string) reflect.Value {

// GetOperator returns interface based on attribute value
func (t Target) GetOperator(attr string) (types.ValueType, error) {
if attr == "" {
return nil, nil
}
value := t.GetAttrValue(attr)
switch value.Kind() {
case reflect.Bool:
Expand Down
7 changes: 7 additions & 0 deletions evaluation/target_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ func TestTarget_GetOperator(t1 *testing.T) {
"weight": 99.99,
}},
args: struct{ attr string }{attr: "weight"}, want: types.Number(99.99)},
{name: "empty operator", fields: struct {
Identifier string
Name *string
Anonymous bool
Attributes map[string]interface{}
}{Identifier: "harness", Name: nil, Anonymous: false, Attributes: map[string]interface{}{}},
args: struct{ attr string }{attr: ""}, want: nil},
}
for _, tt := range tests {
val := tt
Expand Down