FFM-11470 Fix analytics panic with nil target attributes #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybharness
approved these changes
May 13, 2024
erdirowlands
commented
May 13, 2024
|
|
||
| targetAnalytics.iterate(func(key string, target evaluation.Target) { | ||
| targetAttributes := make([]metricsclient.KeyValue, 0) | ||
| if target.Attributes != nil { |
There was a problem hiding this comment.
This is the nil check that was missing that would result in a panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The analytics code was refactored in #150 , and a
nilcheck for target attributes was accidentally removed. This meant if an evaluation was made with a target with no attributes, we would dereference a nil pointer and a panic would occur when analytics are processed:This PR:
Adds a nil check before dereferencing target attributes
Extracts out evaluation/target metrics processing code into separate methods, so that they can be unit tested
Adds unit tests for the newly extracted methods, and
sendDataAndResetCacheAlso retracts [v0.1.21, v0.1.22] due to this bug being critical and easily encountered.
Bumps golang.org/x/net v0.25.0 for CVE-2023-45288
Testing
attributesoranonymousis nil.