FFM-11164 Re-generate Client and Metrics API code, plus fixes #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pi has been updated" This reverts commit 44722df.
FFM-11164 Re-gen OAPI spec using v2 of oapi-codegen
erdirowlands
commented
Apr 10, 2024
| @@ -769,13 +748,49 @@ func getLogger(options ...ConfigOption) logger.Logger { | |||
| return dummyConfig.Logger | |||
| } | |||
|
|
|||
| // findErrorInResponse parses an auth response and returns the response error if it exists | |||
| func findErrorInResponse(resp *rest.AuthenticateResponse) *rest.Error { | |||
There was a problem hiding this comment.
The types have changed here, presumably because of the v2 tool
erdirowlands
commented
Apr 10, 2024
| @@ -196,8 +196,8 @@ func (e Evaluator) evaluateVariationMap(variationsMap []rest.VariationMap, targe | |||
| for _, variationMap := range variationsMap { | |||
| if variationMap.Targets != nil { | |||
| for _, t := range *variationMap.Targets { | |||
| if *t.Identifier != "" && *t.Identifier == target.Identifier { | |||
There was a problem hiding this comment.
Again types have changed. Now a string instead of *String
erdirowlands
commented
Apr 10, 2024
|
|
||
| require ( | ||
| github.com/cenkalti/backoff/v4 v4.2.1 | ||
| github.com/deepmap/oapi-codegen v1.11.0 | ||
| github.com/getkin/kin-openapi v0.94.0 | ||
| github.com/deepmap/oapi-codegen/v2 v2.1.0 |
There was a problem hiding this comment.
v2 has pretty significant benefits, mainly around reduced dependency bundle. See https://www.jvt.me/posts/2023/10/23/oapi-codegen-v2-decrease/
andybharness
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The OAPI Client and Metrics API code has not been re-generated since 2021. We have a need to integrate new changes for a feature, so this PR re-generates the code using the latest spec.
oapi-codegenwas updated tov2and I've generated using that, which resulted in some breaking changes with types returned by the auth endpoint, which I've fixed.paramsandrequestEditorsTesting
TestGrid
Manual: