Skip to content

Conversation

ShibamD
Copy link
Collaborator

@ShibamD ShibamD commented Sep 3, 2025

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.

Description

  • Please describe your changes: __________________________________
  • Jira/GitHub Issue numbers (if any): ______________________________
  • Preview links/images (Internal contributors only): __________________

PR lifecycle

We aim to merge PRs within one week or less, but delays happen sometimes.

If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.

PRs must meet these requirements to be merged:

  • Successful preview build.
  • Code owner review.
  • No merge conflicts.
  • Release notes/new features docs: Feature/version released to at least one prod environment.

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ khushisharmaharness
❌ ShibamD
You have signed the CLA already but the status is still pending? Let us recheck it.

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b80b6b38c8f1bde3094547--harness-developer.netlify.app

some left
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b8328cdc5ef775f03d3517--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b959f2da571317fff979c5--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b95abbd8cb90179f969cef--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b961df3910ea007c3e32b2--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68b96a40ea7c6c1324541d89--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68be7f737e1db63b27344a98--harness-developer.netlify.app

Copy link
Collaborator

@richardblack-Harness richardblack-Harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates to the DMS components. LGTM!
I'd be a little conscious of the amount of screenshots. Not a blocker but something to keep in mind for future PRs.

Screenshots can become outdated quickly.

@ShibamD
Copy link
Collaborator Author

ShibamD commented Sep 8, 2025

Nice updates to the DMS components. LGTM! I'd be a little conscious of the amount of screenshots. Not a blocker but something to keep in mind for future PRs.

Screenshots can become outdated quickly.

Thanks, @richardblack-Harness, for the appreciation. 😎, and yup, will keep a check on the SS quantity.

Copy link
Collaborator

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of Vignesh's comments need to be addressed

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68c05eb5b7452f0f816600d4--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://68c05f93d287df1133e6e691--harness-developer.netlify.app

Copy link
Collaborator

@richardblack-Harness richardblack-Harness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a structural and DMS perspective.

@khushisharmaharness khushisharmaharness merged commit 4cdbcdd into main Sep 9, 2025
4 checks passed
@khushisharmaharness khushisharmaharness deleted the custom-user-group branch September 9, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants