Skip to content

remove keyboard listener from resizer #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+21 −29
Closed

remove keyboard listener from resizer #2129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/ui/locales/en/views.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,15 @@
"failure": "Failure",
"label": "Status",
"favorite": "Favorites"
},
"tagsOption": {
"label": "Tags"
},
"connectorIdentifierOption": {
"label": "Connector Identifier"
},
"descriptionOption": {
"label": "Description"
}
},
"connectivityStatus": "Connectivity status",
Expand Down
9 changes: 9 additions & 0 deletions packages/ui/locales/fr/views.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,15 @@
"failure": "Échec",
"label": "Statut",
"favorite": "Favorites"
},
"tagsOption": {
"label": "Tags"
},
"connectorIdentifierOption": {
"label": "Connector Identifier"
},
"descriptionOption": {
"label": "Description"
}
},
"connectivityStatus": "État de la connexion",
Expand Down
32 changes: 3 additions & 29 deletions packages/ui/src/views/repo/components/draggable-sidebar-divider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export const DraggableSidebarDivider: React.FC<DraggableSidebarDividerProps> = (
className
}) => {
const handleMouseDown = useCallback(
(e: React.MouseEvent<HTMLButtonElement>) => {
(e: React.MouseEvent<HTMLDivElement>) => {
const startX = e.clientX
const startWidth = width
const container = containerRef?.current || document
Expand All @@ -47,36 +47,10 @@ export const DraggableSidebarDivider: React.FC<DraggableSidebarDividerProps> = (
[width, setWidth, minWidth, maxWidth, containerRef]
)

const handleKeyDown = useCallback(
(e: React.KeyboardEvent<HTMLButtonElement>) => {
const step = e.shiftKey ? 50 : 10 // Larger steps with Shift key

switch (e.key) {
case 'ArrowLeft':
e.preventDefault()
setWidth(Math.max(minWidth, width - step))
break
case 'ArrowRight':
e.preventDefault()
setWidth(Math.min(maxWidth, width + step))
break
case 'Home':
e.preventDefault()
setWidth(minWidth) // Minimum width
break
case 'End':
e.preventDefault()
setWidth(maxWidth) // Maximum width
break
}
},
[setWidth, minWidth, maxWidth, width]
)

return (
<button
<div
tabIndex={-1}
onMouseDown={handleMouseDown}
onKeyDown={handleKeyDown}
className={cn(
'after:bg-cn-3 focus:after:bg-cn-brand relative w-px shrink-0 cursor-col-resize select-none after:transition-[width,background,left] before:absolute before:left-[-150%] before:top-0 before:h-full before:w-1 after:absolute after:top-0 after:left-0 after:h-full after:w-px hover:after:left-[-150%] hover:after:w-1 focus:after:left-[-150%] focus:after:w-1',
className
Expand Down