Skip to content

fix overflow in authors filter dropdown #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

fix overflow in authors filter dropdown #2125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/ui/src/components/filters/filter-box-wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,15 @@ const FilterBoxWrapper = ({
>
<DropdownMenu.Trigger asChild>
<Button variant="secondary" size="sm" className="px-2.5 py-1.5">
<div className="flex items-center gap-x-1.5 text-1">
<Text as="span" color="foreground-1">
<Layout.Grid align="center" columns="auto 1fr" gapX="2xs">
<Text as="span" color="foreground-1" truncate>
{filterLabel}
{!!valueLabel && ': '}
</Text>
<Text as="span">{valueLabel}</Text>
</div>
<Text as="span" truncate>
{valueLabel}
</Text>
</Layout.Grid>
<IconV2 className="chevron-down text-icons-1" name="nav-arrow-down" size="2xs" />
</Button>
</DropdownMenu.Trigger>
Expand Down
8 changes: 4 additions & 4 deletions packages/ui/src/views/repo/pull-request/pull-request-list-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,12 @@ const PullRequestListPage: FC<PullRequestPageProps> = ({
email
}: Pick<PrincipalType, 'display_name' | 'email'>): React.ReactNode =>
display_name !== email ? (
<Layout.Horizontal gap="3xs" align="center" className="flex-wrap">
<Text wrap="nowrap">{display_name}</Text>
<Text color="foreground-3" variant="body-single-line-normal" lineClamp={1}>
<Layout.Grid gap="3xs" align="center" columns="auto auto">
<Text truncate>{display_name}</Text>
<Text color="foreground-3" variant="body-single-line-normal" truncate>
({email})
</Text>
</Layout.Horizontal>
</Layout.Grid>
) : (
<Text lineClamp={1}>{display_name}</Text>
)
Expand Down