Skip to content

Commit ef95323

Browse files
fix overflow in authors filter dropdown
1 parent 7ffda11 commit ef95323

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

packages/ui/src/components/filters/filter-box-wrapper.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,15 @@ const FilterBoxWrapper = ({
5252
>
5353
<DropdownMenu.Trigger asChild>
5454
<Button variant="secondary" size="sm" className="px-2.5 py-1.5">
55-
<div className="flex items-center gap-x-1.5 text-1">
56-
<Text as="span" color="foreground-1">
55+
<Layout.Grid align="center" columns="auto 1fr" gapX="2xs">
56+
<Text as="span" color="foreground-1" truncate>
5757
{filterLabel}
5858
{!!valueLabel && ': '}
5959
</Text>
60-
<Text as="span">{valueLabel}</Text>
61-
</div>
60+
<Text as="span" truncate>
61+
{valueLabel}
62+
</Text>
63+
</Layout.Grid>
6264
<IconV2 className="chevron-down text-icons-1" name="nav-arrow-down" size="2xs" />
6365
</Button>
6466
</DropdownMenu.Trigger>

packages/ui/src/views/repo/pull-request/pull-request-list-page.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,12 @@ const PullRequestListPage: FC<PullRequestPageProps> = ({
126126
email
127127
}: Pick<PrincipalType, 'display_name' | 'email'>): React.ReactNode =>
128128
display_name !== email ? (
129-
<Layout.Horizontal gap="3xs" align="center" className="flex-wrap">
130-
<Text wrap="nowrap">{display_name}</Text>
131-
<Text color="foreground-3" variant="body-single-line-normal" lineClamp={1}>
129+
<Layout.Grid gap="3xs" align="center" columns="auto auto">
130+
<Text truncate>{display_name}</Text>
131+
<Text color="foreground-3" variant="body-single-line-normal" truncate>
132132
({email})
133133
</Text>
134-
</Layout.Horizontal>
134+
</Layout.Grid>
135135
) : (
136136
<Text lineClamp={1}>{display_name}</Text>
137137
)

0 commit comments

Comments
 (0)