Skip to content

Commit 7ffda11

Browse files
fix favorite button focus (#2118)
* fix favorite button focus * fixes
1 parent 31a2c52 commit 7ffda11

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

packages/ui/src/components/filters/filters-field.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { useMemo, useState } from 'react'
22

3-
import { Button } from '@components/button'
43
import { Checkbox } from '@components/checkbox'
54
import { Label } from '@components/form-primitives'
65
import { cn } from '@utils/cn'
@@ -102,17 +101,18 @@ const FilterFieldInternal = <T extends string, V extends FilterValueTypes, Custo
102101
const checkboxFilter = filter as FilterField<boolean>
103102
const checkboxId = `checkbox-${uniqId}`
104103
return (
105-
// TODO Need to remove button once we get the designs for checkbox filter
106-
<Button variant="secondary" size="sm" className="gap-x-2.5 px-2.5 py-1.5">
104+
<Label
105+
className="rounded-3 bg-cn-gray-soft border-cn-background-softgray cursor-pointer border px-2.5 py-1.5 [&>.cn-label-text]:flex [&>.cn-label-text]:items-center [&>.cn-label-text]:gap-x-2.5"
106+
htmlFor={checkboxId}
107+
>
107108
<Checkbox
108109
id={checkboxId}
109110
checked={checkboxFilter.value}
110111
onCheckedChange={value => onUpdateFilter(value as V)}
112+
className="relative z-[1]"
111113
/>
112-
<Label className="grid-cols-none" htmlFor={checkboxId}>
113-
<span>{filterOption.filterFieldConfig?.label}</span>
114-
</Label>
115-
</Button>
114+
{filterOption.filterFieldConfig?.label}
115+
</Label>
116116
)
117117
}
118118
default:

packages/ui/tailwind-utils-config/components/stacked-list.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export default {
4848
},
4949

5050
'&-link': {
51-
'@apply absolute inset-0 w-full rounded-3': ''
51+
'@apply absolute inset-0 w-full rounded-3 !z-0': ''
5252
},
5353

5454
'&-thumbnail': {

0 commit comments

Comments
 (0)