Fix for view id setting #4821
Open
Fix for view id setting #4821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR looks fine. It's important to note that this change only applies when the node is syncing. Consensus operations should not be active during synchronization. |
|
cc @GheisMohammadi thanks for review and approval |
sophoah
approved these changes
Jan 29, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced with log message like this one
"shardID":0,"myBlock":3,"myViewID":2,the only one way how it's possible is https://github.com/harmony-one/harmony/blob/dev/consensus/consensus_v2.go#L399 where we set block number, but not view id. I checked logs, and it shows that method
syncNotReadyChanwas called.