-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add br
& zstd
to supported compression 🗜️ algos
#4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bricss
wants to merge
25
commits into
hapijs:master
Choose a base branch
from
bricss:feat/add-br+sztd-with-priority-opts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+464
−39
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
77e8ffd
feat: add brotli to supported compression 🗜️
bricss 3b168b5
chore: address comments 📝
bricss 0d8cdd4
chore: address comments 📝
bricss a302743
feat: add br & zstd to supported compression 🗜️ algos
bricss f3cb451
fix: cure ⚕️ ci
bricss 16d3e98
feat: adjust default priority 🎛️
bricss 36db0b6
feat: make built-in `br` & `zstd` algos opt-in and disabled by default
bricss a5ba404
chore: brush up 💄
bricss b26b41a
feat: add support for compression 🗜 options 🎛️
bricss ec58da7
fix: fixate 🪛 types
bricss b5f50e6
fix: fixate 🪛 types, take 2 🎬
bricss 3a64184
chore: clean up 🧽
bricss 0f05108
feat: address comments 📝
bricss 6792069
feat: reverse ↩️ engine 🚂 version
bricss 7888aad
feat: reverse ↩️ ci min node version 🔢
bricss 9a4336d
feat: betterment 💈
bricss 31c1b4b
feat: address comments 📝
bricss 08bf768
fix: cure 🩹 code coverage
bricss 22fac0d
refactor: refinement ⚗️
bricss 2163c18
fix: adjust 🪛 default params
bricss df96b0f
feat: betterment 💈
bricss d5e7fa8
feat: betterment 💈 take 2 🎬
bricss af8b50b
refactor: refinement ⚗️ take 2 🎬
bricss 498ba9f
feat: add opt to disable decompression ⛔
bricss f5607aa
feat: improve tests 🧪
bricss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to update the common encoding with
'gzip, deflate, br, zstd'
, as this is used by both Chrome and Firefox. This can go in a separate PR.